[P4-dev] P4-16 HLIR with struct support?

Antonin Bas antonin at barefootnetworks.com
Thu May 11 21:29:57 EDT 2017


I just merged the pull request.

On Thu, May 11, 2017 at 5:27 PM, <hemant at mnkcg.com> wrote:

> Great, thanks much!
>
>
>
> Hemant
>
>
>
> *From:* Mihai Budiu [mailto:mbudiu at vmware.com]
> *Sent:* Thursday, May 11, 2017 8:24 PM
> *To:* hemant at mnkcg.com; 'Antonin Bas' <antonin at barefootnetworks.com>
> *Cc:* 'p4-dev' <p4-dev at lists.p4.org>
>
> *Subject:* RE: [P4-dev] P4-16 HLIR with struct support?
>
>
>
> The pull request is in the queue, has been approved and is awaiting
> someone to click the “merge” button.
>
> I will rebase it on master to make it easier; after each rebase the tests
> have to run again…
>
>
>
> Mihai
>
>
>
> *From:* hemant at mnkcg.com [mailto:hemant at mnkcg.com <hemant at mnkcg.com>]
> *Sent:* Thursday, May 11, 2017 5:21 PM
> *To:* 'Antonin Bas' <antonin at barefootnetworks.com>; Mihai Budiu <
> mbudiu at vmware.com>
> *Cc:* 'p4-dev' <p4-dev at lists.p4.org>
> *Subject:* RE: [P4-dev] P4-16 HLIR with struct support?
>
>
>
> The issue I filed was #583 and thanks to Mihai who expedited the fix and
> committed the code to a p4c-clone branch.   So how soon can I expect this
> fix to be in the mainline p4lang/p4c?   I found the cloned branch below but
> this not look to be a release vehicle I can use to get this fix, right?
>
>
>
> https://github.com/mbudiu-vmw/p4c-clone/tree/issue583
>
>
>
> thanks,
>
>
>
> Hemant
>
>
>
> *From:* P4-dev [mailto:p4-dev-bounces at lists.p4.org
> <p4-dev-bounces at lists.p4.org>] *On Behalf Of *hemant at mnkcg.com
> *Sent:* Monday, May 08, 2017 7:06 PM
> *To:* 'Antonin Bas' <antonin at barefootnetworks.com>
> *Cc:* 'p4-dev' <p4-dev at lists.p4.org>
> *Subject:* Re: [P4-dev] P4-16 HLIR with struct support?
>
>
>
> Ok, thanks.  I will open an issue – thanks.
>
>
>
> *From:* Antonin Bas [mailto:antonin at barefootnetworks.com
> <antonin at barefootnetworks.com>]
> *Sent:* Monday, May 08, 2017 1:05 PM
> *To:* hemant at mnkcg.com
> *Cc:* Mihai Budiu <mbudiu at vmware.com>; p4-dev <p4-dev at lists.p4.org>
> *Subject:* Re: [P4-dev] P4-16 HLIR with struct support?
>
>
>
> Compilation fails for me as well, but with a different error message:
>
>
>
> includes/headers.p4(18): error: header ipv4_t: Duplicates declaration
> header ipv4_t
>
> header_type ipv4_t {
>
> ^
>
> includes/headers.p4(18)
>
> header_type ipv4_t {
>
> ^
>
> error: 1 errors encountered, aborting compilation
>
>
>
> You may want to open an issue in p4lang/p4c
>
>
>
> On Sun, May 7, 2017 at 2:53 PM, <hemant at mnkcg.com> wrote:
>
> In the p4-hlir/tests directory, there is a stateful.p4 file (
> https://github.com/p4lang/p4-hlir/blob/master/tests/stateful.p4
> <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_p4lang_p4-2Dhlir_blob_master_tests_stateful.p4&d=DwMFaQ&c=uilaK90D4TOVoH58JNXRgQ&r=tGW6TKXajnoXSyy1S1P4DHGPe8sj54GGvw-b21n7aWg&m=QQR_rqeCkQ57g5qbv0S5qybtBwnNYlmIYGG8bzVU3hU&s=wdDzic1TiRjb0oaV97B63m3EIMShHpklidoZgzGR1Uk&e=>
> ).
>
>
>
> I used the following p4c compilation.  The compiler fails to compile this
> P4-14 file.  Did I do anything wrong using the p4c compiler to compile
> P4-14 code?
>
> ~/p4-hlir/tests$ p4c -S -x p4-14 stateful.p4
>
>
>
>
>
> includes/parser.p4(46): error: : No header type ipv4_t
>
> header ipv4_t ipv4;
>
> ^^^^^^^^^^^^^^^^^^^
>
> includes/parser.p4(46)
>
> header ipv4_t ipv4;
>
>        ^^^^^^
>
> error: 1 errors encountered, aborting compilation
>
>
>
> ~/p4-hlir/tests$
>
>
>
> Best,
>
>
>
> Hemant
>
>
>
> *From:* Antonin Bas [mailto:antonin at barefootnetworks.com]
> *Sent:* Monday, May 01, 2017 11:19 PM
> *To:* hemant at mnkcg.com
> *Cc:* p4-dev <p4-dev at lists.p4.org>
> *Subject:* Re: [P4-dev] P4-16 HLIR with struct support?
>
>
>
> Hi Hemant,
>
>
>
> There is no plan to update p4-hlir to support P4_16.
>
> Instead we encourage people to move to the new p4lang/p4c compiler,
> written in C++, which supports both P4_14 and P4_16: https://github.com/
> p4lang/p4c
> <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_p4lang_p4c&d=DwMFaQ&c=uilaK90D4TOVoH58JNXRgQ&r=tGW6TKXajnoXSyy1S1P4DHGPe8sj54GGvw-b21n7aWg&m=QQR_rqeCkQ57g5qbv0S5qybtBwnNYlmIYGG8bzVU3hU&s=QmieA6_5Bj2-YP017bNz-I3HrtiH_LeNlgb4EboNZ0Y&e=>
>
> We will keep maintaining p4-hlir for the time being, but no new features
> will be added.
>
>
>
> Best,
>
>
>
> Antonin
>
>
>
> On Mon, May 1, 2017 at 7:16 PM, <hemant at mnkcg.com> wrote:
>
> I am interested is using a P4-16 struct in a test program with p4-hlir.  I
> don’t see the HLIR updated yet with struct from P4-16.
>
>
>
> Hemant
>
>
> _______________________________________________
> P4-dev mailing list
> P4-dev at lists.p4.org
> http://lists.p4.org/mailman/listinfo/p4-dev_lists.p4.org
> <https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.p4.org_mailman_listinfo_p4-2Ddev-5Flists.p4.org&d=DwMFaQ&c=uilaK90D4TOVoH58JNXRgQ&r=tGW6TKXajnoXSyy1S1P4DHGPe8sj54GGvw-b21n7aWg&m=QQR_rqeCkQ57g5qbv0S5qybtBwnNYlmIYGG8bzVU3hU&s=AsdKpIAvMWIT8dxuu3-4-tBPv96_EWZKx9xsaS2FU4k&e=>
>
>
>
>
>
> --
>
> Antonin
>
>
>
>
>
> --
>
> Antonin
>



-- 
Antonin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.p4.org/pipermail/p4-dev_lists.p4.org/attachments/20170511/55117d79/attachment-0002.html>


More information about the P4-dev mailing list